Auto merge of #5126 - gilescope:cycle-error-message, r=alexcrichton
authorbors <bors@rust-lang.org>
Fri, 9 Mar 2018 19:40:03 +0000 (19:40 +0000)
committerbors <bors@rust-lang.org>
Fri, 9 Mar 2018 19:40:03 +0000 (19:40 +0000)
commitd147e103746784600cf9acf497efdedeb1695bb4
tree38db731cdfe580d984f1fbbedb764d2250082677
parent5f83bb4044f32b60d06717c609610f67411fc671
parent3088fa07d224de7d13e93a8dc19634020bcef152
Auto merge of #5126 - gilescope:cycle-error-message, r=alexcrichton

Error message for package "depends on itself" lists the packages in the cycle.

I got a cycle while trying to build someone else's code and cargo's error message didn't point me in the right direction, just mentioned there was a cycle. I thought we could be a bit more helpful.

Don't know what you think of {:#?} as the display but it seemed minimal code so I thought I'd start with that. I could compress the output to one package per line if preferred.
src/cargo/core/resolver/mod.rs
src/cargo/lib.rs
tests/testsuite/build.rs